Skip to content

chore(build): fix build warnings for Dynamic Actor Isolation feature #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore(build): fix build warnings for Dynamic Actor Isolation feature #4005

wants to merge 8 commits into from
+366 −124

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jun 12, 2025 •
edited by thisisabhash
Loading

Issue #

None

Description

  • Enable DynamicActorIsolation feature for all targets
  • Add @unchecked Sendable annotations for build warnings

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash marked this pull request as ready for review July 31, 2025 17:04
@thisisabhash thisisabhash requested a review from a team as a code owner July 31, 2025 17:04
@thisisabhash thisisabhash changed the title fix: swift 6 warnings chore(build): fix build warnings for Dynamic Actor Isolation feature Jul 31, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 95.18072% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.69%. Comparing base (e3d6f63) to head (69cf560).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Amplify/Amplify.swift 95.00% 1 Missing ⚠️
...fy/Categories/Auth/AuthCategory+UserBehavior.swift 0.00% 1 Missing ⚠️
...gnitoAuthPlugin/Actions/SignUp/ConfirmSignUp.swift 0.00% 1 Missing ⚠️
...nitoAuthPlugin/Actions/SignUp/InitiateSignUp.swift 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4005      +/-   ##
==========================================
+ Coverage   67.51%   67.69%   +0.17%     
==========================================
  Files        1130     1130              
  Lines       52639    52658      +19     
==========================================
+ Hits        35539    35646     +107     
+ Misses      17100    17012      -88
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (-0.03%) ⬇️
AWSPluginsCore 69.26% <100.00%> (ø)
Amplify 47.94% <90.47%> (+0.11%) ⬆️
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.67% <96.72%> (+0.12%) ⬆️
DataStore_plugin_unit_test 84.08% <ø> (+0.76%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.53% <ø> (ø)
Predictions_plugin_unit_test 34.77% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.87% <ø> (ø)
unit_tests 67.69% <95.18%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsh62 @thisisabhash